setTimeout, setInterval and clearInterval (and the same clearTimeout) implementations
#4130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…imeout`) implementations This adds non-async implementations of the `setTimeout`/`setInterval` API functions. They are by default registered in the context when registering all APIs from `boa_runtime`.
jedel1043
requested changes
Jan 23, 2025
Comment on lines
+142
to
+167
| /// Create a new `TimeoutJob` with a timeout and a job. | ||
| #[must_use] | ||
| pub fn new_unchecked(job: NativeJob, timeout: i64) -> Self { | ||
| Self { timeout, job } | ||
| } | ||
|
|
||
| /// Create a new `TimeoutJob` with a job and a timeout in milliseconds in the future. | ||
| #[must_use] | ||
| pub fn delayed(job: NativeJob, delay: u64, context: &mut Context) -> Self { | ||
| Self::new_unchecked(job, context.host_hooks().utc_now() + (delay as i64)) | ||
| } | ||
|
|
||
| /// Creates a new `TimeoutJob` from a closure and a timeout as [`std::time::SystemTime`]. | ||
| #[must_use] | ||
| pub fn new<F>(f: F, timeout: std::time::SystemTime) -> Self | ||
| where | ||
| F: FnOnce(&mut Context) -> JsResult<JsValue> + 'static, | ||
| { | ||
| Self::new_unchecked( | ||
| NativeJob::new(f), | ||
| timeout | ||
| .duration_since(std::time::UNIX_EPOCH) | ||
| .expect("Invalid SystemTime") | ||
| .as_millis() as i64, | ||
| ) | ||
| } |
There was a problem hiding this comment.
I think we shouldn't depend so heavily on SystemTime. Seems weird to tie one of our job types to something that could panic on certain platforms, and users won't be able to sandbox the engine from the OS if this is in place.
Having new(job: NativeJob, timeout: i64) sounds enough for all usecases, and the specific executor can use the provided timeout to schedule the job as it fits.
Comment on lines
+125
to
+126
| /// The instant this job should be run, in msec since epoch. This will be compared | ||
| /// to the host's [`HostHooks::utc_now`] method. |
There was a problem hiding this comment.
I don't think we should mention details about SimpleJobExecutor, since every executor can handle the timeout amount in a different way.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds non-async implementations of the
setTimeout/setIntervalAPI functions. They are by default registered in the context when registering all APIs fromboa_runtime.This adds a new type of jobs that implement
HostEnqueueTimeoutJob(see https://tc39.es/ecma262/#sec-hostenqueuetimeoutjob).This requires #4141 to be merged first.